[GitHub] [inlong] fuweng11 commented on a diff in pull request #5053: [INLONG-5052][Manager] The workflow that failed to execute still failed, but returned success

Thu, 14 Jul 2022 07:02:05 -0700 


fuweng11 commented on code in PR #5053:
URL: https://github.com/apache/inlong/pull/5053#discussion_r921191759


##########
inlong-manager/manager-workflow/src/main/java/org/apache/inlong/manager/workflow/core/impl/TaskServiceImpl.java:
##########
@@ -67,6 +68,8 @@ public WorkflowContext transfer(Integer taskId, String 
remark, List<String> to,
     public WorkflowContext complete(Integer taskId, String remark, String 
operator) {
         WorkflowContext context = workflowContextBuilder
                 .buildContextForTask(taskId, WorkflowAction.COMPLETE, remark, 
operator);
+        ServiceTask serviceTask = (ServiceTask) 
context.getActionContext().getTask();

Review Comment:
   noļ¼Œjust one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to