EMsnap commented on code in PR #5134:
URL: https://github.com/apache/inlong/pull/5134#discussion_r925094920
##########
inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/utils/FlumeConfigGenerator.java:
##########
@@ -51,14 +54,15 @@ public static Map<String, String>
generateFlumeConfiguration(SortTaskConfig task
*
* @param flumeConf
*/
- private static void appendChannels(Map<String, String> flumeConf, String
name) {
+ private static void appendChannels(Map<String, String> flumeConf, String
name, Map<String, String> sinkParams) {
StringBuilder builder = new StringBuilder();
String channelName = name + "Channel";
flumeConf.put(name + ".channels", channelName);
String prefix =
builder.append(name).append(".channels.").append(channelName).append(".").toString();
builder.setLength(0);
String channelType = builder.append(prefix).append("type").toString();
- String channelClass =
CommonPropertiesHolder.getString(KEY_SORT_CHANNEL_TYPE);
+ String channelClass = sinkParams.getOrDefault(KEY_SORT_CHANNEL_TYPE,
Review Comment:
final a variable inside a method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
