healchow commented on code in PR #5172:
URL: https://github.com/apache/inlong/pull/5172#discussion_r927227517
##########
inlong-sort/pom.xml:
##########
@@ -40,7 +40,7 @@
<module>sort-connectors</module>
<module>sort-core</module>
<module>sort-dist</module>
- <module>sort-end-to-end-tests</module>
+ <!--<module>sort-end-to-end-tests</module>-->
Review Comment:
Please do not change this module, the unit tests error for this module will
be fixed later.
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sortstandalone/SortSourceStreamInfo.java:
##########
@@ -17,12 +17,38 @@
package org.apache.inlong.manager.common.pojo.sortstandalone;
+import com.google.gson.Gson;
import lombok.Data;
+import org.apache.pulsar.shade.org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
@Data
public class SortSourceStreamInfo {
private static final long serialVersionUID = 1L;
+ private static final Logger LOGGER =
LoggerFactory.getLogger(SortSourceStreamInfo.class);
String sortClusterName;
String sortTaskName;
String groupId;
+ String extParams;
+ Map<String, String> extParamsMap;
+
+ public Map<String, String> getExtParamsMap() {
+ if (extParamsMap != null) {
+ return extParamsMap;
+ }
+ if (StringUtils.isNotBlank(extParams)) {
+ try {
+ Gson gson = new Gson();
+ extParamsMap = gson.fromJson(extParams, Map.class);
+ } catch (Throwable t) {
+ LOGGER.error(t.getMessage(), t);
Review Comment:
Suggest setting more info in the error log, the exception stack trace has
already included the message info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
