healchow commented on code in PR #5221:
URL: https://github.com/apache/inlong/pull/5221#discussion_r929709183
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -372,20 +372,21 @@ public void updateAfterApprove(InlongGroupApproveRequest
approveRequest, String
throw new WorkflowListenerException("inlong group status is
[wait_approval], not allowed to approve again");
}
- // update status to [GROUP_APPROVE_PASSED]
- this.updateStatus(groupId, GroupStatus.APPROVE_PASSED.getCode(),
operator);
-
// update other info for inlong group after approve
if (StringUtils.isNotBlank(approveRequest.getInlongClusterTag())) {
entity.setInlongGroupId(approveRequest.getInlongGroupId());
entity.setInlongClusterTag(approveRequest.getInlongClusterTag());
entity.setModifier(operator);
+ entity.setStatus(GroupStatus.APPROVE_PASSED.getCode());
int rowCount = groupMapper.updateByIdentifierSelective(entity);
if (rowCount != InlongConstants.AFFECTED_ONE_ROW) {
LOGGER.error("inlong group has already updated with group
id={}, curVersion={}",
entity.getInlongGroupId(), entity.getVersion());
throw new BusinessException(ErrorCodeEnum.CONFIG_EXPIRED);
}
+ }else {
Review Comment:
Please add one blank after `}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
