pocozh commented on code in PR #5239:
URL: https://github.com/apache/inlong/pull/5239#discussion_r931727471
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/pulsarzone/PulsarZoneSinkContext.java:
##########
@@ -192,7 +192,7 @@ public void addSendMetric(DispatchProfile currentRecord,
String bid) {
*/
public void addSendFailMetric() {
Map<String, String> dimensions = new HashMap<>();
- dimensions.put(DataProxyMetricItem.KEY_CLUSTER_ID,
this.getProxyClusterId());
+ dimensions.put(DataProxyMetricItem.KEY_CLUSTER_ID,
this.getClusterId());
Review Comment:
> Now, the SinkContext has not `proxyClusterId`, it only has `ClusterId`.
The unify will not be done in this PR.
Yep, SinkContext has `ClusterId`, so those child classes don't need
`proxyClusterId`. Maybe, could you unify in this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
