gosonzhang commented on code in PR #5288:
URL: https://github.com/apache/inlong/pull/5288#discussion_r933914743


##########
inlong-tubemq/tubemq-client-twins/tubemq-client-go/client/heartbeat.go:
##########
@@ -129,9 +129,9 @@ func (h *heartbeatManager) consumerHB2Master() {
                                return
                        }
                }
+               h.consumer.masterHBRetry = 0

Review Comment:
   @TszKitLo40, there should be a logical omission:
   1. The master address obtained by each heartbeat is performed through 
getCurrentMasterAddr()[a];
   2. In getCurrentMasterAddr(), according to the valid master address obtained 
during registration [b], locate the heartbeat through the curr_master_addr_ 
parameter;
   3. The curr_master_addr_ value is effectively determined through the 
registration between the client and the Master [c]
   
   
   a. 
https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-client-twins/tubemq-client-cpp/src/baseconsumer.cc#L510
   b. 
https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-client-twins/tubemq-client-cpp/src/baseconsumer.cc#L1414
   c. 
https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-client-twins/tubemq-client-cpp/src/baseconsumer.cc#L374
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to