leosanqing commented on code in PR #5263:
URL: https://github.com/apache/inlong/pull/5263#discussion_r933981084
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/core/sink/SQLServerSinkServiceTest.java:
##########
@@ -98,4 +106,68 @@ public void testGetAndUpdate() {
deleteSink(sinkId);
}
+ /**
+ * Just using in local test.
+ */
+ @Disabled
+ public void testDbResource() {
+ String url = "jdbc:sqlserver://127.0.0.1:1434;databaseName=inlong;";
+ String username = "sa";
+ String password = "123456";
+ String tableName = "test01";
+ String schemaName = "dbo";
+
+ try (Connection connection = SQLServerJdbcUtils.getConnection(url,
username, password);) {
+ SQLServerTableInfo tableInfo = bulidTableInfo(schemaName,
tableName);
+ SQLServerJdbcUtils.createSchema(connection, schemaName);
+ SQLServerJdbcUtils.createTable(connection, tableInfo);
+ List<SQLServerColumnInfo> addColumns = buildAddColumns();
+ SQLServerJdbcUtils.addColumns(connection, schemaName, tableName,
addColumns);
+ List<SQLServerColumnInfo> columns =
SQLServerJdbcUtils.getColumns(connection, schemaName, tableName);
+ Assertions.assertEquals(columns.size(),
tableInfo.getColumns().size() + addColumns.size());
+ } catch (Exception e) {
+ // print to local console
+ e.printStackTrace();
+ }
+ }
+
+ /**
+ * Build add SQLServer column info.
+ *
+ * @return {@link List}
+ */
+ private final List<SQLServerColumnInfo> buildAddColumns() {
+ List<SQLServerColumnInfo> addCloums = new ArrayList<>();
+ SQLServerColumnInfo test1 = new SQLServerColumnInfo("test1",
"varchar(40)", "test1");
+ addCloums.add(test1);
+ SQLServerColumnInfo test2 = new SQLServerColumnInfo("test2",
"varchar(40)", "test2");
+ addCloums.add(test2);
+ return addCloums;
+ }
+
+ /**
+ * Build test SQLServer table info.
+ *
+ * @param schemaName SqlServer schema name
+ * @param tableName SqlServer table name
+ * @return {@link SQLServerTableInfo}
+ */
+ private final SQLServerTableInfo bulidTableInfo(String schemaName, String
tableName) {
+ SQLServerTableInfo tableInfo = new SQLServerTableInfo();
+ tableInfo.setTableName(tableName);
+ tableInfo.setComment("test01 ");
+ tableInfo.setPrimaryKey("id");
+ tableInfo.setSchemaName(schemaName);
+ List<SQLServerColumnInfo> columnInfos = new ArrayList<>();
+ tableInfo.setColumns(columnInfos);
+ SQLServerColumnInfo id = new SQLServerColumnInfo("id", "int", "id");
+ columnInfos.add(id);
+ SQLServerColumnInfo cell = new SQLServerColumnInfo("cell",
"varchar(20)", "cell");
+ columnInfos.add(cell);
+ SQLServerColumnInfo name = new SQLServerColumnInfo("name",
"varchar(40)", "name");
+ columnInfos.add(name);
+ tableInfo.setPrimaryKey("id");
Review Comment:
Personally, the add operation can be combined into one sentence using
Guava's Lists.new ArrayList().
```
List<SQLServerColumnInfo> columnInfos = Lists.newArrayList(
new SQLServerColumnInfo("id", "int", "id"),
new SQLServerColumnInfo("cell", "varchar(20)", "cell"),
new SQLServerColumnInfo("name", "varchar(40)", "name")
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
