[GitHub] [inlong] gong commented on a diff in pull request #4882: [INLONG-4814][Sort][Manager] Declare the primary key for sink table when the query contains update/delete

Mon, 01 Aug 2022 02:52:09 -0700 


gong commented on code in PR #4882:
URL: https://github.com/apache/inlong/pull/4882#discussion_r934347173


##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/table/JdbcDialects.java:
##########
@@ -44,6 +45,7 @@ public final class JdbcDialects {
         DIALECTS.add(new TDSQLPostgresDialect());
         DIALECTS.add(new SqlServerDialect());
         DIALECTS.add(new OracleDialect());
+        DIALECTS.add(new ClickHouseDialect());

Review Comment:
   > If it is not added to the list, the unit test will be abnormal here 
![企业微信截图_f539e39a-2dcc-4498-99d7-bb1d593e032f](https://user-images.githubusercontent.com/20356765/182117661-b52daf46-6d1e-4b13-b2fd-f3d07d48f35c.png)
   
   UT error reason is  
https://github.com/apache/inlong/pull/4882#discussion_r934339275. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to