healchow commented on code in PR #5381:
URL: https://github.com/apache/inlong/pull/5381#discussion_r939684874
##########
inlong-manager/manager-web/src/test/java/org/apache/inlong/manager/web/controller/DataNodeControllerTest.java:
##########
@@ -36,23 +37,26 @@ class DataNodeControllerTest extends WebBaseTest {
@Resource
DataNodeEntityMapper dataNodeEntityMapper;
- DataNodeRequest getDataNodeRequest() {
- return DataNodeRequest.builder()
- .name("hiveNode1")
- .type("HIVE")
- .url("127.0.0.1:8080")
- .username("admin")
- .token("123")
- .inCharges("admin")
- .build();
+ HiveDataNodeRequest getHiveDataNodeRequest() {
+ HiveDataNodeRequest hiveDataNodeRequest = new HiveDataNodeRequest();
+ hiveDataNodeRequest.setName("hiveNode1");
+ hiveDataNodeRequest.setType("HIVE");
Review Comment:
Please use a String constant from DataNodeType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
