Greedyu commented on code in PR #504: URL: https://github.com/apache/inlong-website/pull/504#discussion_r939881222
########## docs/modules/agent/metrics.md: ########## @@ -15,16 +15,26 @@ Users can add similar JMX (port and authentication are adjusted according to the -Dcom.sun.management.jmxremote.ssl=false ``` +The `agent.properties` file needs to specify the listener class +```properties +# The listener of JMX is AgentJmxMetricListener +agent.domainListeners=org.apache.inlong.agent.metrics.AgentJmxMetricListener +``` + ## Prometheus Configuration You can declare whether to enable Prometheus and HTTPServer port in `agent.properties`. ```properties -# the default is false -agent.prometheus.enable=true -# the default is 8080 -agent.prometheus.exporter.port=8080 +# The listener of Prometheus is AgentPrometheusMetricListener +agent.domainListeners=org.apache.inlong.agent.metrics.AgentPrometheusMetricListener +# the default is 9080 +agent.prometheus.exporter.port=9080 ``` +## User-Defined Configuration Review Comment: Modified to Custom ########## i18n/zh-CN/docusaurus-plugin-content-docs/current/modules/agent/metrics.md: ########## @@ -14,17 +14,26 @@ Agent 提供了 JMX 和 Prometheus 方式的监控指标能力，默认使用 JM -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false ``` +`agent.properties` 文件需要指定监听类 +```properties +# JMX监听类是AgentJmxMetricListener +agent.domainListeners=org.apache.inlong.agent.metrics.AgentJmxMetricListener +``` ## Prometheus 配置 用户可以在`agent.properties`中声明是否启用Prometheus以及HTTPServer端口号 ```properties -# 默认不启用Prometheus -agent.prometheus.enable=true -# 默认端口为8080 -agent.prometheus.exporter.port=8080 +# Prometheus监听类是AgentPrometheusMetricListener +agent.domainListeners=org.apache.inlong.agent.metrics.AgentPrometheusMetricListener +# 默认端口为9080 +agent.prometheus.exporter.port=9080 ``` +## 自定义 配置 Review Comment: resolve -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
