EMsnap commented on code in PR #5568:
URL: https://github.com/apache/inlong/pull/5568#discussion_r949977335
##########
inlong-sort/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/table/PulsarDynamicTableSource.java:
##########
@@ -233,35 +233,62 @@ public ScanRuntimeProvider
getScanRuntimeProvider(ScanContext context) {
valueDeserialization,
producedTypeInfo);
final ClientConfigurationData clientConfigurationData =
PulsarClientUtils.newClientConf(serviceUrl, properties);
- FlinkPulsarSource<RowData> source = new FlinkPulsarSource<>(
- adminUrl,
- clientConfigurationData,
- deserializationSchema,
- properties
- );
-
- if (watermarkStrategy != null) {
- source.assignTimestampsAndWatermarks(watermarkStrategy);
- }
-
- switch (startupOptions.startupMode) {
- case EARLIEST:
- source.setStartFromEarliest();
- break;
- case LATEST:
- source.setStartFromLatest();
- break;
- case SPECIFIC_OFFSETS:
-
source.setStartFromSpecificOffsets(startupOptions.specificOffsets);
- break;
- case EXTERNAL_SUBSCRIPTION:
- MessageId subscriptionPosition = MessageId.latest;
- if
(CONNECTOR_STARTUP_MODE_VALUE_EARLIEST.equals(startupOptions.externalSubStartOffset))
{
- subscriptionPosition = MessageId.earliest;
- }
-
source.setStartFromSubscription(startupOptions.externalSubscriptionName,
subscriptionPosition);
+ if (adminUrl != null) {
+ org.apache.flink.streaming.connectors.pulsar.FlinkPulsarSource
source =
Review Comment:
method is a little bit too long, suggest to extract different method for
adminUrl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
