pocozh commented on code in PR #5595:
URL: https://github.com/apache/inlong/pull/5595#discussion_r960167501
##########
inlong-sdk/dataproxy-sdk/src/main/java/org/apache/inlong/sdk/dataproxy/network/Sender.java:
##########
@@ -726,4 +736,26 @@ public boolean isIdleClient(NettyClient client) {
return true;
}
+ private NettyClient getClient(LoadBalance loadBalance, EncodeObject
encodeObject) {
Review Comment:
Is it better to remove this into `ClientMgr`? Then, methods such as
`asyncSendMessage` can directly use previous signature, and no need to add
additional parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
