woofyzhao commented on code in PR #5758:
URL: https://github.com/apache/inlong/pull/5758#discussion_r960175333
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -224,23 +231,27 @@ public Boolean update(SinkRequest request, String
operator) {
}
}
List<SinkField> fields = request.getSinkFieldList();
- // Remove id in sinkField when save
+ // Remove id in sinkField before saving or updating
if (CollectionUtils.isNotEmpty(fields)) {
fields.forEach(sinkField -> sinkField.setId(null));
Review Comment:
Can we just remove the id field to be inserted in the sql stmt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
