EMsnap commented on code in PR #5763:
URL: https://github.com/apache/inlong/pull/5763#discussion_r960780949
##########
inlong-sort/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/table/DynamicPulsarDeserializationSchema.java:
##########
@@ -132,6 +140,39 @@ public void
open(DeserializationSchema.InitializationContext context) throws Exc
}
+ /**
+ * reflect get metricGroup
+ *
+ * @param context
+ * @return
+ */
+ private MetricGroup
getMetricGroup(DeserializationSchema.InitializationContext context)
Review Comment:
> Why not modify FlinkPulsarSource#open directly?
same with me, no need to reflect the metric group. It's ok if we modify the
user metrics group since we build the source by ourselves
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
