[GitHub] [inlong] healchow commented on a diff in pull request #5684: [INLONG-5666][SortStandalone] SortSdkSource supports init multiple Sort SDK to improve performance

Mon, 05 Sep 2022 03:16:12 -0700 


healchow commented on code in PR #5684:
URL: https://github.com/apache/inlong/pull/5684#discussion_r962741168


##########
inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/SortSdkSource.java:
##########
@@ -249,14 +257,18 @@ private Map<String, String> 
getSortClientConfigParameters() {
      */
     @Override
     public void stopConsumer() {
-        sortClient.getConfig().setStopConsume(true);
+        for (SortClient sortClient : sortClients) {
+            sortClient.getConfig().setStopConsume(true);
+        }
     }
 
     /**
      * recoverConsumer
      */
     @Override
     public void recoverConsumer() {
-        sortClient.getConfig().setStopConsume(false);
+        for (SortClient sortClient : sortClients) {
+            sortClient.getConfig().setStopConsume(false);
+        }
     }
-}
+}

Review Comment:
   No need to delete the blank line at the end of the file, otherwise there is 
a symble in GitHub.
   
![image](https://user-images.githubusercontent.com/31994335/188426080-75c6d823-e59b-473c-a292-e0b2877e94bc.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to