EMsnap commented on code in PR #6123:
URL: https://github.com/apache/inlong/pull/6123#discussion_r991757209
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/DynamicKafkaSerializationSchema.java:
##########
@@ -176,6 +189,17 @@ public void setPartitions(int[] partitions) {
@Override
public String getTargetTopic(RowData element) {
+ // Only support dynamic topic when the topicPattern is specified
+ // and the valueSerialization is RawFormatSerializationSchema
+ if (valueSerialization instanceof RawFormatSerializationSchema &&
StringUtils.isNotBlank(topicPattern)) {
+ try {
+ return
DynamicSchemaFormatFactory.getFormat(innerValueDecodingFormat)
+ .parse(element.getBinary(0), topicPattern);
Review Comment:
extract the index 0 as constant and add a comment why it should be 0 would
be better since people may be confused here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
