[GitHub] [inlong] woofyzhao commented on a diff in pull request #6168: [INLONG-6151][Manager] Add data cleansing task and optimize query indexes

Wed, 19 Oct 2022 00:16:34 -0700 


woofyzhao commented on code in PR #6168:
URL: https://github.com/apache/inlong/pull/6168#discussion_r999029700


##########
inlong-manager/manager-dao/src/main/resources/mappers/InlongGroupEntityMapper.xml:
##########
@@ -211,9 +211,8 @@
     <select id="selectDeletedGroupIds" resultType="java.lang.String">
         select inlong_group_id
         from inlong_group
-        where modify_time &lt;= #{lastModifyTime,jdbcType=TIMESTAMP}
-        group by inlong_group_id
-        having min(is_deleted) > 0
+        where is_deleted > 0

Review Comment:
   It could be possible that there are two groups of the same inlong_group_id 
and one of them is deleted but the other one is not, in which case the 
non-deleted one will also be selected and incorrectly cleansed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to