healchow commented on code in PR #6227:
URL: https://github.com/apache/inlong/pull/6227#discussion_r1001288781
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/tubemq/TubeMQResourceOperator.java:
##########
@@ -66,24 +76,32 @@ public void createQueueForGroup(InlongGroupInfo groupInfo,
String operator) {
}
try {
+ List<InlongStreamBriefInfo> streamInfoList =
streamService.getTopicList(groupId);
+ if (streamInfoList == null || streamInfoList.isEmpty()) {
+ log.warn("skip to create tube topic as no streams for
groupId={}", groupId);
+ return;
+ }
// 1. create tubemq topic
String clusterTag = groupInfo.getInlongClusterTag();
TubeClusterInfo tubeCluster = (TubeClusterInfo)
clusterService.getOne(clusterTag, null, ClusterType.TUBEMQ);
String topicName = groupInfo.getMqResource();
tubeMQOperator.createTopic(tubeCluster, topicName, operator);
log.info("success to create tubemq topic for groupId={}", groupId);
-
- // 2. create tubemq consumer group
- // consumer naming rules: clusterTag_topicName_consumer_group
- String consumeGroup = clusterTag + "_" + topicName +
"_consumer_group";
- tubeMQOperator.createConsumerGroup(tubeCluster, topicName,
consumeGroup, operator);
- log.info("success to create tubemq consumer group for groupId={}",
groupId);
-
- // insert the consumer group info
- Integer id = consumeService.saveBySystem(groupInfo, topicName,
consumeGroup);
- log.info("success to save inlong consume [{}] for
consumerGroup={}, groupId={}, topic={}",
- id, consumeGroup, groupId, topicName);
-
+ for (InlongStreamBriefInfo stream : streamInfoList) {
+ List<StreamSink> streamSinks = sinkService.listSink(groupId,
stream.getInlongStreamId());
+ for (StreamSink sink : streamSinks) {
+ // 2. create tubemq consumer group
+ // consumer naming rules:
clusterTag_topicName_consumer_group
+ String consumeGroup = clusterTag + "_" + topicName + "_" +
sink.getId() + "_consumer_group";
Review Comment:
Suggest extracting a constant, as
`PulsarResourceOperator#PULSAR_SUBSCRIPTION` did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
