luchunliang commented on code in PR #6277:
URL: https://github.com/apache/inlong/pull/6277#discussion_r1004155630
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/source/pulsar/PulsarSourceRequest.java:
##########
@@ -60,7 +60,7 @@ public class PulsarSourceRequest extends SourceRequest {
private String dataEncoding = StandardCharsets.UTF_8.toString();
@ApiModelProperty(value = "Data separator")
- private String dataSeparator = DataSeparator.VERTICAL_BAR.getSeparator();
+ private String dataSeparator = "124";
Review Comment:
magic number
It is better.
private String dataSeparator = String.valueOf((int)'|');
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/stream/InlongStreamRequest.java:
##########
@@ -65,7 +64,7 @@ public class InlongStreamRequest {
private String dataEncoding = StandardCharsets.UTF_8.toString();
@ApiModelProperty(value = "Data separator")
- private String dataSeparator = DataSeparator.VERTICAL_BAR.getSeparator();
+ private String dataSeparator = "44";
Review Comment:
magic number
It is better.
private String dataSeparator = String.valueOf((int)',');
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
