healchow commented on code in PR #6299:
URL: https://github.com/apache/inlong/pull/6299#discussion_r1006394543
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/SortServiceImpl.java:
##########
@@ -73,21 +74,23 @@ public SortSourceConfigResponse getSourceConfig(String
clusterName, String sortT
}
@Override
- public ListSortStatusResponse listSortStatus(ListSortStatusRequest
request) {
- Preconditions.checkNotNull(sortStatusPoller, "sort job status poller
not initialized");
+ public List<SortStatusInfo> listSortStatus(SortStatusRequest request) {
+ Preconditions.checkNotNull(sortPoller, "sort status poller not
initialized, please try later");
List<InlongGroupInfo> groupInfoList =
request.getInlongGroupIds().stream()
- .map(groupId ->
groupService.get(groupId)).collect(Collectors.toList());
- Map<String, SortStatus> statusMap =
sortStatusPoller.poll(groupInfoList, request.getCredentials());
- log.debug("get sort status map = {}", statusMap);
- return ListSortStatusResponse.builder().statusMap(statusMap).build();
+ .map(groupId -> groupService.get(groupId))
+ .collect(Collectors.toList());
+
+ List<SortStatusInfo> statusInfos =
sortPoller.pollSortStatus(groupInfoList, request.getCredentials());
+ log.debug("success list sort status for request={}, result={}",
request, statusInfos);
+
+ return statusInfos;
}
@Override
public void acceptPlugin(Plugin plugin) {
- if (!(plugin instanceof ProcessPlugin)) {
- return;
+ if (plugin instanceof PollerPlugin) {
+ PollerPlugin pollerPlugin = (PollerPlugin) plugin;
+ sortPoller = pollerPlugin.getSortPoller();
}
- ProcessPlugin processPlugin = (ProcessPlugin) plugin;
- sortStatusPoller = processPlugin.createSortStatusPoller();
}
Review Comment:
Change the `plugin.yaml` to support loading more than one class in the
manager plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
