thesumery commented on code in PR #6312:
URL: https://github.com/apache/inlong/pull/6312#discussion_r1007558564
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/JsonDynamicSchemaFormat.java:
##########
@@ -99,7 +99,7 @@ public abstract class JsonDynamicSchemaFormat extends
AbstractDynamicSchemaForma
protected JsonDynamicSchemaFormat() {
this.rowDataConverters =
- new JsonToRowDataConverters(true, false,
TimestampFormat.ISO_8601);
+ new JsonToRowDataConverters(false, false,
TimestampFormat.ISO_8601);
Review Comment:
it's recommanded to config `TimestampFormat` and `ignoreParseErrors` as a
configurable parameter.But `failOnMissingField` should not be exported. Here
are the reasons.
1. `failOnMissingField` should always be false beacuse old data always fill
modified field, it means it always miss some fields.So if we want to extract
old data in canal json, we should always set this parameters to `false`.
I will submit an issue to follow it.
[](https://github.com/apache/inlong/issues/6313)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
