yunqingmoswu commented on code in PR #6346:
URL: https://github.com/apache/inlong/pull/6346#discussion_r1010032309
##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisStreamLoad.java:
##########
@@ -80,7 +81,7 @@ protected boolean isRedirectable(String method) {
this.httpClient = httpClientBuilder.build();
}
- public void load(String db, String tbl, String value) throws
StreamLoadException {
+ public void load(String db, String tbl, String value, SinkMetricData
metricData) throws StreamLoadException {
Review Comment:
It is recommended to modify the method return instead of modifying the input
parameters to support metric collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
