woofyzhao commented on code in PR #6388:
URL: https://github.com/apache/inlong/pull/6388#discussion_r1013546957
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -254,15 +238,6 @@ public Boolean update(SinkRequest request, String
operator) {
StreamSinkOperator sinkOperator =
operatorFactory.getInstance(request.getSinkType());
sinkOperator.updateOpt(request, nextStatus, operator);
- // If the stream is [CONFIG_SUCCESSFUL], then asynchronously start the
[CREATE_STREAM_RESOURCE] process
Review Comment:
So what's the appropriate time to restart after config updates ? Perhaps
it's better be launched by end user in a separate call. According to the Single
Responsibility Principle the service update handler should only perform no
other than config updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
