yunqingmoswu commented on code in PR #6404:
URL: https://github.com/apache/inlong/pull/6404#discussion_r1013672117
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleReadableMetaData.java:
##########
@@ -87,18 +94,18 @@ public Object read(SourceRecord record) {
/**
* It indicates the time that the change was made in the database. If the
record is read from
- * snapshot of the table instead of the change stream, the value is always
0.
+ * snapshot of the table instead of the binlog, the value is always 0.
*/
- OP_TS(
Review Comment:
Would it be better to keep?
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleReadableMetaData.java:
##########
@@ -72,9 +77,11 @@ public Object read(SourceRecord record) {
}
}),
- /** Name of the database that contain the row. */
- DATABASE_NAME(
Review Comment:
Would it be better to keep?
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleReadableMetaData.java:
##########
@@ -47,9 +47,11 @@
/** Defines the supported metadata columns for {@link OracleTableSource}. */
public enum OracleReadableMetaData {
- /** Name of the table that contain the row. */
- TABLE_NAME(
Review Comment:
Would it be better to keep?
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleReadableMetaData.java:
##########
@@ -59,9 +61,12 @@ public Object read(SourceRecord record) {
return StringData.fromString(getMetaData(record,
AbstractSourceInfo.TABLE_NAME_KEY));
}
}),
- /** Name of the schema that contain the row. */
- SCHEMA_NAME(
Review Comment:
Would it be better to keep?
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/Metadata.java:
##########
@@ -54,14 +54,6 @@ default String getMetadataKey(MetaField metaField) {
case OP_TS:
metadataKey = "op_ts";
break;
- case DATA:
Review Comment:
Why remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
