yunqingmoswu commented on code in PR #6424:
URL: https://github.com/apache/inlong/pull/6424#discussion_r1015143803
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/DebeziumJsonDynamicSchemaFormat.java:
##########
@@ -289,16 +281,6 @@ public List<RowData> extractRowData(JsonNode data, RowType
rowType) {
return extractRowData(payload, rowType);
}
- /**
- * Get the identifier of this dynamic schema format
- *
- * @return The identifier of this dynamic schema format
- */
- @Override
- public String identifier() {
Review Comment:
Maybe it is better to keep the 'identifier()'?
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/DebeziumJsonDynamicSchemaFormat.java:
##########
@@ -44,7 +44,6 @@
*/
public class DebeziumJsonDynamicSchemaFormat extends JsonDynamicSchemaFormat {
- private static final String IDENTIFIER = "debezium-json";
Review Comment:
Maybe it is better to keep the 'IDENTIFIER'?
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -163,4 +163,11 @@ public final class Constants {
.booleanType()
.defaultValue(true)
.withDescription("Whether ignore the single table erros
when multiple sink writing scenario.");
+
+ public static final ConfigOption<Boolean>
SINK_MULTIPLE_TYPE_MAP_SPARK_ENGINE_ENABLE =
+ ConfigOptions.key("sink.multiple.typemap.spark.engine.enable")
Review Comment:
Maybe it is better to call 'sink.multiple.typemap-compatible-with-spark'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
