gong commented on code in PR #6524:
URL: https://github.com/apache/inlong/pull/6524#discussion_r1021098059
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -465,7 +465,7 @@ public Boolean delete(String groupId, String operator) {
// logically delete the associated extension info
groupExtMapper.logicDeleteAllByGroupId(groupId);
- if
(GroupStatus.allowedLogicDelete(GroupStatus.forCode(entity.getStatus()))) {
+ if
(GroupStatus.notAllowedDelete(GroupStatus.forCode(entity.getStatus()))) {
streamService.logicDeleteAll(groupId, operator);
Review Comment:
Maybe,
`GroupStatus.notAllowedDelete(GroupStatus.forCode(entity.getStatus()))` modify
to `!GroupStatus.notAllowedDelete(GroupStatus.forCode(entity.getStatus()))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
