[GitHub] [inlong] healchow commented on a diff in pull request #6534: [INLONG-6533][Manager] Fix the problem of manager did not distribute the task according to the clusterName

Mon, 14 Nov 2022 18:37:38 -0800 


healchow commented on code in PR #6534:
URL: https://github.com/apache/inlong/pull/6534#discussion_r1022257824


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java:
##########
@@ -283,12 +283,14 @@ private DataConfig getFileTaskFromEntity(TaskRequest 
taskRequest, StreamSourceEn
 
     private List<DataConfig> fetchIssuedTasks(TaskRequest taskRequest) {
         final String agentIp = taskRequest.getAgentIp();
+        final String agentClusterName = taskRequest.getAgentIp();

Review Comment:
   Is the Agent IP also used as Agent cluster name?



##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java:
##########
@@ -283,12 +283,14 @@ private DataConfig getFileTaskFromEntity(TaskRequest 
taskRequest, StreamSourceEn
 
     private List<DataConfig> fetchIssuedTasks(TaskRequest taskRequest) {
         final String agentIp = taskRequest.getAgentIp();
+        final String agentClusterName = taskRequest.getAgentIp();

Review Comment:
   Is the Agent IP also used as the Agent cluster name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to