[GitHub] [inlong] haifxu commented on a diff in pull request #6571: [INLONG-6570][Manager] Ignore the length of the field when building sort config

Sun, 20 Nov 2022 18:41:28 -0800 


haifxu commented on code in PR #6571:
URL: https://github.com/apache/inlong/pull/6571#discussion_r1027486430


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/FieldInfoUtils.java:
##########
@@ -172,7 +174,7 @@ public static FormatInfo convertFieldFormat(String type) {
      */
     public static FormatInfo convertFieldFormat(String type, String format) {
         FormatInfo formatInfo;
-        FieldType fieldType = FieldType.forName(type);
+        FieldType fieldType = 
FieldType.forName(StringUtils.substringBefore(type, LEFT_BRACKET));

Review Comment:
   The sink table was created before this, and the field type here is only used 
for `sort` and does not require length. 
   
![企业微信截图_16689978292227](https://user-images.githubusercontent.com/58519431/202951772-cdf25454-6221-4d07-b58d-247c05a14561.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to