EMsnap commented on code in PR #6595:
URL: https://github.com/apache/inlong/pull/6595#discussion_r1027881543
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/ClickHouseDialect.java:
##########
@@ -154,6 +178,67 @@ public String getDeleteStatement(String tableName,
String[] conditionFields) {
Arrays.stream(conditionFields)
.map(f -> format("%s = :%s", quoteIdentifier(f), f))
.collect(Collectors.joining(" AND "));
- return "ALTER TABLE " + quoteIdentifier(tableName) + " DELETE WHERE "
+ conditionClause;
+ Pair<String, String> pair = getDatabaseAndTableName(tableName);
Review Comment:
use a name that illustrate the actual data, since "pair" can be infered from
its class type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
