Yizhou-Yang commented on code in PR #6618: URL: https://github.com/apache/inlong/pull/6618#discussion_r1032008227
########## inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/dirty/sink/log/LogDirtySink.java: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sort.base.dirty.sink.log; + +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonProcessingException; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.JsonNode; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.types.DataType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.inlong.sort.base.dirty.DirtyData; +import org.apache.inlong.sort.base.dirty.sink.DirtySink; +import org.apache.inlong.sort.base.dirty.utils.FormatUtils; +import org.apache.inlong.sort.base.util.LabelUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Arrays; +import java.util.Map; +import static org.apache.flink.table.data.RowData.createFieldGetter; + +/** + * Log dirty sink that is used to print log + * + * @param <T> + */ +public class LogDirtySink<T> implements DirtySink<T> { + + private static final long serialVersionUID = 1L; + + private static final Logger LOG = LoggerFactory.getLogger(LogDirtySink.class); + + private final RowData.FieldGetter[] fieldGetters; + private final String[] fieldNames; + private final String format; + private final String fieldDelimiter; + + public LogDirtySink(String format, String fieldDelimiter, + DataType[] fieldDataTypes, String[] fieldNames) { + this.format = format; + this.fieldDelimiter = fieldDelimiter; + this.fieldNames = fieldNames; + final LogicalType[] logicalTypes = Arrays.stream(fieldDataTypes) Review Comment: what are the possible "LogicalType"s for a dirty sink? will there be problems around incompatible logical types? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
