EMsnap commented on code in PR #6599:
URL: https://github.com/apache/inlong/pull/6599#discussion_r1033084335
##########
inlong-sort/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/FlinkDynamicTableFactory.java:
##########
@@ -64,37 +65,43 @@
*
* <p>
* Factory for creating configured instances of {@link IcebergTableSource} and
{@link
- * IcebergTableSink}.We modify KafkaDynamicTableSink to support append-mode .
+ * IcebergTableSink}.We modify IcebergDynamicTableSink to support append-mode .
* </p>
*/
public class FlinkDynamicTableFactory implements DynamicTableSinkFactory,
DynamicTableSourceFactory {
static final String FACTORY_IDENTIFIER = "iceberg-inlong";
- private static final ConfigOption<String> CATALOG_NAME =
+ public static final ConfigOption<String> CATALOG_NAME =
Review Comment:
why public this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
