chestnut-c commented on code in PR #6670: URL: https://github.com/apache/inlong/pull/6670#discussion_r1035500256
########## inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/phase/ReadPhaseMetricData.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sort.base.metric.phase; + +import static org.apache.inlong.sort.base.Constants.READ_PHASE_TIMESTAMP; + +import java.util.Map; +import org.apache.flink.metrics.Counter; +import org.apache.flink.metrics.MetricGroup; +import org.apache.inlong.sort.base.metric.MetricData; +import org.apache.inlong.sort.base.metric.MetricOption; +import org.apache.inlong.sort.base.metric.ThreadSafeCounter; + +/** + * A collection class for handling read phase metric data + */ +public class ReadPhaseMetricData implements MetricData { Review Comment: > If you think about it from this point of view, I suggest using a more precise name, which currently represents a relatively large rhetorical question. This entity can be used as long as there is a switch between the snapshot and incremental phase. If there is no stages information, the connector can not be used. so for the reading phase, it is common under the premise that the connector has a reading phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
