healchow commented on code in PR #6677:
URL: https://github.com/apache/inlong/pull/6677#discussion_r1038982208
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongGroupController.java:
##########
@@ -95,6 +97,12 @@ public Response<InlongGroupTopicInfo> getTopic(@PathVariable
String groupId) {
return Response.success(groupService.getTopic(groupId));
}
+ @GetMapping(value = "/group/listTopicsByTag/{clusterTag}")
Review Comment:
It is written as `@PostMapping(value = "/group/listTopics")`, and receives a
request body like `/group/list`, which can facilitate the extension of
parameters other than `clusterTag`, such as querying by a list of `groupId`.
If you do not modify it this way, then if you need to query the topic list
according to the `groupId` or another field in the future, you need to add
another API to support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
