leezng commented on code in PR #6757:
URL: https://github.com/apache/inlong/pull/6757#discussion_r1040414222
##########
inlong-dashboard/src/metas/sinks/defaults/Hive.ts:
##########
@@ -117,39 +117,33 @@ export default class HiveSink extends SinkInfo implements
DataWithBackend, Rende
password: string;
@FieldDecorator({
- type: 'input',
- rules: [{ required: true }],
- props: values => ({
- disabled: [110, 130].includes(values?.status),
- placeholder: 'jdbc:hive2://127.0.0.1:10000',
- }),
- })
- @I18n('JDBC URL')
- jdbcUrl: string;
-
- @FieldDecorator({
- type: 'input',
- rules: [{ required: true }],
- tooltip: i18n.t('meta.Sinks.DataPathHelp'),
- props: values => ({
- disabled: [110, 130].includes(values?.status),
- placeholder: 'hdfs://127.0.0.1:9000/user/hive/warehouse/default',
- }),
- })
- @I18n('meta.Sinks.Hive.DataPath')
- dataPath: string;
-
- @FieldDecorator({
- type: 'input',
+ type: 'select',
rules: [{ required: true }],
- tooltip: i18n.t('meta.Sinks.Hive.ConfDirHelp'),
props: values => ({
+ showSearch: true,
disabled: [110, 130].includes(values?.status),
- placeholder: '/usr/hive/conf',
+ options: {
+ requestService: {
Review Comment:
Changed to a wording like
https://github.com/apache/inlong/blob/master/inlong-dashboard/src/pages/ProcessDetail/GroupConfig.tsx#L115,
the effect is that when entering keywords, you can adjust the API to search,
not just search on the front end
##########
inlong-dashboard/src/metas/sinks/defaults/Hive.ts:
##########
@@ -117,39 +117,33 @@ export default class HiveSink extends SinkInfo implements
DataWithBackend, Rende
password: string;
@FieldDecorator({
- type: 'input',
- rules: [{ required: true }],
- props: values => ({
- disabled: [110, 130].includes(values?.status),
- placeholder: 'jdbc:hive2://127.0.0.1:10000',
- }),
- })
- @I18n('JDBC URL')
- jdbcUrl: string;
-
- @FieldDecorator({
- type: 'input',
- rules: [{ required: true }],
- tooltip: i18n.t('meta.Sinks.DataPathHelp'),
Review Comment:
This has been removed, but I see that node's dictionary key specification is
used incorrectly, can you help to modify it?
See: (`meta.Sinks.` prefix is wrong)
https://github.com/apache/inlong/blob/master/inlong-dashboard/src/metas/nodes/defaults/Hive.ts#L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
