healchow commented on code in PR #6857:
URL: https://github.com/apache/inlong/pull/6857#discussion_r1046716952
##########
inlong-dashboard/src/metas/sinks/defaults/Elasticsearch.ts:
##########
@@ -92,6 +92,28 @@ export default class ElasticsearchSink
@I18n('meta.Sinks.ES.IndexName')
indexName: string;
+ @FieldDecorator({
+ type: 'input',
+ rules: [{ required: true }],
+ props: values => ({
+ disabled: [110, 130].includes(values?.status),
+ }),
+ })
+ @ColumnDecorator()
+ @I18n('meta.Sinks.ES.PrimaryKey')
Review Comment:
The `PrimaryKey` for Elasticsearch is so strange, as I know, Elasticsearch
does not have a concept of primary key, see here:
https://discuss.elastic.co/t/get-data-primary-key/235128
If needed, the user can specify the `_id` field, otherwise, Elasticsearch
will auto-generate one for each document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
