[inlong] branch master updated: [INLONG-6876][Manager] Always enable "scan.incremental.snapshot" for MySQL extract node (#6877)

[healchow]

This is an automated email from the ASF dual-hosted git repository.

healchow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/inlong.git


The following commit(s) were added to refs/heads/master by this push:
     new a4234c544 [INLONG-6876][Manager] Always enable 
"scan.incremental.snapshot" for MySQL extract node (#6877)
a4234c544 is described below

commit a4234c5441df08f36a767b2675d6056388d74551
Author: Schnapps <zpen...@connect.ust.hk>
AuthorDate: Wed Dec 14 19:36:50 2022 +0800

    [INLONG-6876][Manager] Always enable "scan.incremental.snapshot" for MySQL 
extract node (#6877)
---
 .../apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java   | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git 
a/inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java
 
b/inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java
index acba5b006..6c60528ff 100644
--- 
a/inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java
+++ 
b/inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java
@@ -131,19 +131,14 @@ public class ExtractNodeUtils {
         final List<String> tableNames = Splitter.on(",").splitToList(tables);
         List<FieldInfo> fieldInfos = 
parseFieldInfos(binlogSource.getFieldList(), binlogSource.getSourceName());
         final String serverTimeZone = binlogSource.getServerTimezone();
-        boolean incrementalSnapshotEnabled = true;
 
         // TODO Needs to be configurable for those parameters
         Map<String, String> properties = 
parseProperties(binlogSource.getProperties());
         if (binlogSource.isAllMigration()) {
             // Unique properties when migrate all tables in database
-            incrementalSnapshotEnabled = false;
             properties.put("migrate-all", "true");
         }
-        if (StringUtils.isEmpty(primaryKey)) {
-            incrementalSnapshotEnabled = false;
-            properties.put("scan.incremental.snapshot.enabled", "false");
-        }
+
         return new MySqlExtractNode(binlogSource.getSourceName(),
                 binlogSource.getSourceName(),
                 fieldInfos,
@@ -157,7 +152,7 @@ public class ExtractNodeUtils {
                 database,
                 port,
                 serverId,
-                incrementalSnapshotEnabled,
+                true,
                 serverTimeZone);
     }