kuansix commented on code in PR #6820:
URL: https://github.com/apache/inlong/pull/6820#discussion_r1049188479
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/table/JdbcDynamicTableSink.java:
##########
@@ -93,24 +114,44 @@ private void validatePrimaryKey(ChangelogMode
requestedMode) {
public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
final TypeInformation<RowData> rowDataTypeInformation =
context.createTypeInformation(tableSchema.toRowDataType());
- final JdbcDynamicOutputFormatBuilder builder = new
JdbcDynamicOutputFormatBuilder();
-
- builder.setAppendMode(appendMode);
- builder.setJdbcOptions(jdbcOptions);
- builder.setJdbcDmlOptions(dmlOptions);
- builder.setJdbcExecutionOptions(executionOptions);
- builder.setRowDataTypeInfo(rowDataTypeInformation);
- builder.setFieldDataTypes(tableSchema.getFieldDataTypes());
- builder.setInLongMetric(inlongMetric);
- builder.setAuditHostAndPorts(auditHostAndPorts);
- return SinkFunctionProvider.of(
- new GenericJdbcSinkFunction<>(builder.build()),
jdbcOptions.getParallelism());
+
+ if (multipleSink) {
Review Comment:
> Can this piece of code be merged?
check again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
