dockerzhang commented on code in PR #6943:
URL: https://github.com/apache/inlong/pull/6943#discussion_r1051734320
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/sink/ElasticsearchSinkServiceTest.java:
##########
@@ -97,4 +109,16 @@ public void testGetAndUpdate() {
deleteSink(sinkId);
}
+ private void prepareEsDataNode(String dataNodeName) {
+ ElasticsearchDataNodeRequest request = new
ElasticsearchDataNodeRequest();
+ request.setName(dataNodeName);
+ request.setType(DataNodeType.ELASTICSEARCH);
+ request.setUrl("http://127.0.0.1:9200;http://127.0.0.1:9200");
Review Comment:
http://127.0.0.1:9200;http://127.0.0.1:9200
->
http://127.0.0.1:9200;http://127.0.0.1:9300
It's better to use a different URL.
##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -388,6 +388,7 @@
"meta.Nodes.MySQL.Url": "地址",
"meta.Nodes.MySQL.BackupUrl": "备份地址",
"meta.Nodes.ES.Host": "主机",
+ "meta.Nodes.ES.HostHelp": "要连接到的一台或多台Elasticsearch主机,例如
'http://host_name:9092;http://host_name:9093'",
Review Comment:
要连接到的一台或多台Elasticsearch主机
->
要连接到的一台或多台 Elasticsearch 主机
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]