healchow commented on code in PR #6969:
URL: https://github.com/apache/inlong/pull/6969#discussion_r1052906368
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/kafka/KafkaSourceOperator.java:
##########
@@ -118,9 +116,8 @@ public Map<String, List<StreamSource>>
getSourcesMap(InlongGroupInfo groupInfo,
kafkaSource.setSerializationType(sourceInfo.getSerializationType());
}
- // CSV: InLong message type whose message body is raw CSV
- // Raw-CSV: messages are separated by a specific separator
-
kafkaSource.setWrapWithInlongMsg(streamInfo.getDataType().startsWith(DATA_TYPE_RAW_PREFIX));
+ Integer wrapWithInlongMsg = streamInfo.getWrapWithInlongMsg();
+ kafkaSource.setWrapWithInlongMsg(null == wrapWithInlongMsg || 1 ==
wrapWithInlongMsg);
Review Comment:
`1` is a magic number. Please extract it as a global constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
