fuweng11 commented on code in PR #7001:
URL: https://github.com/apache/inlong/pull/7001#discussion_r1055965721
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/stream/InlongStreamServiceImpl.java:
##########
@@ -514,12 +571,35 @@ public Boolean updateWithoutCheck(InlongStreamRequest
request, String operator)
// update stream fields
updateField(groupId, streamId, request.getFieldList());
// update stream extension infos
- saveOrUpdateExt(groupId, streamId, request.getExtList());
+ List<InlongStreamExtInfo> extList = request.getExtList();
+ extList = packExtParams(request, extList);
+ saveOrUpdateExt(groupId, streamId, extList);
LOGGER.info("success to update inlong stream without check for
groupId={} streamId={}", groupId, streamId);
return true;
}
+ /**
+ * Pack extended attributes into {@link InlongStreamExtInfo}
+ * @param request the request
+ * @param extList the extList from frontend
+ * @return the packed extParams
+ */
+ private List<InlongStreamExtInfo> packExtParams(InlongStreamRequest
request,
Review Comment:
I don't think additional parameters can be added in this way.If there are
more parameters later, the code will become very redundant.
It is recommended to use a DTO class to place additional parameters in ext_
params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
