gosonzhang commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062252527
##########
inlong-manager/manager-test/src/main/resources/h2/apache_inlong_manager.sql:
##########
@@ -330,7 +330,7 @@ CREATE TABLE IF NOT EXISTS `stream_source`
`uuid` varchar(30) DEFAULT NULL COMMENT 'Mac uuid
of the agent running the task',
`data_node_name` varchar(128) DEFAULT NULL COMMENT 'Node
name, which links to data_node table',
`inlong_cluster_name` varchar(128) DEFAULT NULL COMMENT 'Cluster
name of the agent running the task',
- `inlong_cluster_node_tag` varchar(512) DEFAULT NULL COMMENT 'Cluster
node tag',
+ `inlong_cluster_node_group` varchar(512) DEFAULT NULL COMMENT
'Cluster node label',
Review Comment:
label -- > group
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/core/impl/AgentServiceTest.java:
##########
@@ -203,8 +203,8 @@ public void testTagMatch() {
saveSource("tag2,tag3");
saveSource("tag2,tag3");
saveSource("tag4");
- bindTag(true, "tag1");
- bindTag(true, "tag2");
+ bindGroup(true, "tag1");
Review Comment:
tag1 -- > group1
##########
inlong-manager/manager-web/sql/apache_inlong_manager.sql:
##########
@@ -347,7 +347,7 @@ CREATE TABLE IF NOT EXISTS `stream_source`
`uuid` varchar(30) DEFAULT NULL COMMENT 'Mac uuid
of the agent running the task',
`data_node_name` varchar(128) DEFAULT NULL COMMENT 'Node
name, which links to data_node table',
`inlong_cluster_name` varchar(128) DEFAULT NULL COMMENT 'Cluster
name of the agent running the task',
- `inlong_cluster_node_tag` varchar(512) DEFAULT NULL COMMENT 'Cluster
node tag',
+ `inlong_cluster_node_group` varchar(512) DEFAULT NULL COMMENT
'Cluster node label',
Review Comment:
label --> group
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/core/impl/AgentServiceTest.java:
##########
@@ -310,15 +310,15 @@ public void testRematchedWhenSuspend() {
@Test
public void testMismatchedWhenRestart() {
final Pair<String, String> groupStream = saveSource("tag1,tag3");
- bindTag(true, "tag1");
+ bindGroup(true, "tag1");
agent.pullTask();
agent.pullTask(); // report last success status
// suspend and restart
suspendSource(groupStream.getLeft(), groupStream.getRight());
restartSource(groupStream.getLeft(), groupStream.getRight());
- bindTag(false, "tag1");
+ bindGroup(false, "tag1");
Review Comment:
tag1 --> group1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
