gosonzhang commented on code in PR #7279:
URL: https://github.com/apache/inlong/pull/7279#discussion_r1089909547
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/OpenInLongClusterController.java:
##########
@@ -68,93 +70,115 @@ public class OpenInLongClusterController {
@ApiOperation(value = "Get cluster tag by id")
@ApiImplicitParam(name = "id", value = "Cluster ID", dataTypeClass =
Integer.class, required = true)
public Response<ClusterTagResponse> getTag(@PathVariable Integer id) {
+ Preconditions.checkNull(id, ErrorCodeEnum.INVALID_PARAMETER, "tag id
cannot be null");
+ Preconditions.checkNull(LoginUserUtils.getLoginUser(),
ErrorCodeEnum.LOGIN_USER_EMPTY);
return Response.success(clusterService.getTag(id,
LoginUserUtils.getLoginUser()));
}
@PostMapping(value = "/cluster/tag/list")
@ApiOperation(value = "List cluster tags")
public Response<List<ClusterTagResponse>> listTag(@RequestBody
ClusterTagPageRequest request) {
+ Preconditions.checkNull(request, ErrorCodeEnum.INVALID_PARAMETER,
"request cannot be null");
Review Comment:
It will be traced by https://github.com/apache/inlong/issues/7280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
