gosonzhang commented on code in PR #7301:
URL: https://github.com/apache/inlong/pull/7301#discussion_r1092774057
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterServiceImpl.java:
##########
@@ -146,7 +146,7 @@ public Integer saveTag(ClusterTagRequest request, String
operator) {
@Override
public Integer saveTag(ClusterTagRequest request, UserInfo opInfo) {
// only the person in charges can query
- if (!opInfo.getRoles().contains(UserTypeEnum.ADMIN.name())) {
+ if (!opInfo.getAccountType().equals(UserTypeEnum.ADMIN.getCode())) {
Review Comment:
I agree with what you said, but the current practice has not yet completed
authentication and authorization based on roles, so first judge according to
the current implementation based on AccountType, and then deal with it
according to roles after subsequent improvements, or it will become a
functional bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
