gosonzhang commented on code in PR #7243: URL: https://github.com/apache/inlong/pull/7243#discussion_r1093094269
########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/redis/RedisSinkOperator.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.service.sink.redis; + +import static org.apache.inlong.manager.common.enums.ErrorCodeEnum.IP_EMPTY; +import static org.apache.inlong.manager.common.enums.ErrorCodeEnum.PORT_EMPTY; +import static org.apache.inlong.manager.common.enums.ErrorCodeEnum.SINK_SAVE_FAILED; +import static org.apache.inlong.manager.common.enums.ErrorCodeEnum.SINK_TYPE_NOT_SUPPORT; +import static org.apache.inlong.manager.common.util.Preconditions.expectNotBlank; +import static org.apache.inlong.manager.common.util.Preconditions.expectNotEmpty; +import static org.apache.inlong.manager.common.util.Preconditions.expectNotNull; +import static org.apache.inlong.manager.common.util.Preconditions.expectTrue; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.inlong.manager.common.consts.SinkType; +import org.apache.inlong.manager.common.enums.ErrorCodeEnum; +import org.apache.inlong.manager.common.exceptions.BusinessException; +import org.apache.inlong.manager.common.util.CommonBeanUtils; +import org.apache.inlong.manager.dao.entity.StreamSinkEntity; +import org.apache.inlong.manager.pojo.sink.SinkField; +import org.apache.inlong.manager.pojo.sink.SinkRequest; +import org.apache.inlong.manager.pojo.sink.StreamSink; +import org.apache.inlong.manager.pojo.sink.redis.RedisClusterMode; +import org.apache.inlong.manager.pojo.sink.redis.RedisDataType; +import org.apache.inlong.manager.pojo.sink.redis.RedisSchemaMapMode; +import org.apache.inlong.manager.pojo.sink.redis.RedisSink; +import org.apache.inlong.manager.pojo.sink.redis.RedisSinkDTO; +import org.apache.inlong.manager.pojo.sink.redis.RedisSinkRequest; +import org.apache.inlong.manager.service.sink.AbstractSinkOperator; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Service; + +import java.util.Arrays; +import java.util.List; + +/** + * Redis sink operator, such as save or update redis field, etc. + */ +@Service +public class RedisSinkOperator extends AbstractSinkOperator { + + private static final Logger LOGGER = LoggerFactory.getLogger(RedisSinkOperator.class); + private static final int PORT_MAX_VALUE = 65535; + + @Autowired + private ObjectMapper objectMapper; + + @Override + public Boolean accept(String sinkType) { + return SinkType.REDIS.equals(sinkType); + } + + @Override + protected String getSinkType() { + return SinkType.REDIS; + } + + @Override + protected void setTargetEntity(SinkRequest request, StreamSinkEntity targetEntity) { + + if (!this.getSinkType().equals(request.getSinkType())) { + throw new BusinessException(ErrorCodeEnum.SINK_SAVE_FAILED, + SINK_TYPE_NOT_SUPPORT.getMessage() + ": " + getSinkType()); + } + + RedisSinkRequest sinkRequest = (RedisSinkRequest) request; + + String clusterMode = sinkRequest.getClusterMode(); + RedisClusterMode redisClusterMode = RedisClusterMode.of(clusterMode); + + expectNotNull(redisClusterMode, Review Comment: Should the not-null check be placed inside the cast, or add a default cast value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
