fuweng11 commented on code in PR #7326:
URL: https://github.com/apache/inlong/pull/7326#discussion_r1098145658
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/kafka/KafkaResourceOperators.java:
##########
@@ -134,7 +134,13 @@ public void deleteQueueForStream(InlongGroupInfo
groupInfo, InlongStreamInfo str
log.info("begin to delete kafka resource for groupId={} streamId={}",
groupId, streamId);
try {
- this.deleteKafkaTopic(groupInfo, streamInfo.getMqResource());
+ String topicName = streamInfo.getMqResource();
+ if (topicName.equals(streamId)) {
Review Comment:
`Objects.equals(topicName, streamId)`
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/kafka/KafkaSourceOperator.java:
##########
@@ -126,6 +134,17 @@ public Map<String, List<StreamSource>>
getSourcesMap(InlongGroupInfo groupInfo,
}
}
+ // if the SerializationType is still null, set it to the CSV
+ if (StringUtils.isEmpty(kafkaSource.getSerializationType())) {
Review Comment:
`StringUtils.isBlank()`
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/kafka/KafkaSourceOperator.java:
##########
@@ -113,6 +114,13 @@ public Map<String, List<StreamSource>>
getSourcesMap(InlongGroupInfo groupInfo,
kafkaSource.setBootstrapServers(bootstrapServers);
kafkaSource.setTopic(streamInfo.getMqResource());
String serializationType =
DataTypeEnum.forType(streamInfo.getDataType()).getType();
+ String topicName = streamInfo.getMqResource();
+ if (topicName.equals(streamId)) {
Review Comment:
`Objects.equals(topicName, streamId)`
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/kafka/KafkaSourceOperator.java:
##########
@@ -126,6 +134,17 @@ public Map<String, List<StreamSource>>
getSourcesMap(InlongGroupInfo groupInfo,
}
}
+ // if the SerializationType is still null, set it to the CSV
+ if (StringUtils.isEmpty(kafkaSource.getSerializationType())) {
+ kafkaSource.setSerializationType(DataTypeEnum.CSV.getType());
+ }
+ if
(DataTypeEnum.CSV.getType().equalsIgnoreCase(kafkaSource.getSerializationType()))
{
+ kafkaSource.setDataSeparator(streamInfo.getDataSeparator());
+ if (StringUtils.isEmpty(kafkaSource.getDataSeparator())) {
Review Comment:
`StringUtils.isBlank()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
