healchow commented on code in PR #7347:
URL: https://github.com/apache/inlong/pull/7347#discussion_r1102213489
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/RedisExtractNode.java:
##########
@@ -431,4 +434,14 @@ public Map<String, String> tableOptions() {
public String genTableName() {
return String.format("table_%s", getId());
}
+
+ @Override
+ public boolean isVirtual(MetaField metaField) {
+ return false;
+ }
+
+ @Override
+ public Set<MetaField> supportedMetaFields() {
+ return null;
Review Comment:
Will returning a null result in an error? Do we need to return an empty set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]