fuweng11 commented on code in PR #7270: URL: https://github.com/apache/inlong/pull/7270#discussion_r1103946619
########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/kudu/KuduSinkOperator.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.service.sink.kudu; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.commons.collections.CollectionUtils; +import org.apache.commons.lang3.StringUtils; +import org.apache.inlong.manager.common.consts.InlongConstants; +import org.apache.inlong.manager.common.consts.SinkType; +import org.apache.inlong.manager.common.enums.ErrorCodeEnum; +import org.apache.inlong.manager.common.exceptions.BusinessException; +import org.apache.inlong.manager.common.util.CommonBeanUtils; +import org.apache.inlong.manager.dao.entity.StreamSinkEntity; +import org.apache.inlong.manager.pojo.sink.SinkField; +import org.apache.inlong.manager.pojo.sink.SinkRequest; +import org.apache.inlong.manager.pojo.sink.StreamSink; +import org.apache.inlong.manager.pojo.sink.kudu.KuduSink; +import org.apache.inlong.manager.pojo.sink.kudu.KuduSinkDTO; +import org.apache.inlong.manager.pojo.sink.kudu.KuduSinkRequest; +import org.apache.inlong.manager.service.sink.AbstractSinkOperator; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Service; + +import java.util.Arrays; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Kudu sink operator, such as save or update Kudu field, etc. + */ +@Service +public class KuduSinkOperator extends AbstractSinkOperator { + + private static final Logger LOGGER = LoggerFactory.getLogger(KuduSinkOperator.class); + + @Autowired + private ObjectMapper objectMapper; + + @Override + public Boolean accept(String sinkType) { + return SinkType.KUDU.equals(sinkType); + } + + @Override + protected String getSinkType() { + return SinkType.KUDU; + } + + @Override + protected void setTargetEntity(SinkRequest request, StreamSinkEntity targetEntity) { + if (!this.getSinkType().equals(request.getSinkType())) { Review Comment: This statement is always true and is redundant. ########## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/KuduLoadNode.java: ########## @@ -102,15 +96,16 @@ public Map<String, String> tableOptions() { // If the extend attributes starts with .ddl, // it will be passed to the ddl statement of the table - extList.forEach(ext -> { - String keyName = ext.get(EXTEND_ATTR_KEY_NAME); - if (StringUtils.isNoneBlank(keyName) && - keyName.startsWith(DDL_ATTR_PREFIX)) { - String ddlKeyName = keyName.substring(DDL_ATTR_PREFIX.length()); - String ddlValue = ext.get(EXTEND_ATTR_VALUE_NAME); - options.put(ddlKeyName, ddlValue); - } - }); + Map<String, String> properties = getProperties(); + if (properties != null) { + properties.forEach((keyName, ddlValue) -> { + if (StringUtils.isNoneBlank(keyName) && Review Comment: StringUtils.isNotBlank() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
