healchow commented on code in PR #7390:
URL: https://github.com/apache/inlong/pull/7390#discussion_r1111425438
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/node/extract/KafkaExtractNodeTest.java:
##########
@@ -49,7 +51,12 @@ public KafkaExtractNode getTestObject() {
List<FieldInfo> fields = Arrays.asList(
new FieldInfo("name", new StringFormatInfo()),
new FieldInfo("age", new IntFormatInfo()));
- return new KafkaExtractNode("1", "kafka_input", fields, null, null,
"workerCsv",
+ Map<String, String> properties = new HashMap<>();
+ List<String> auditIds = new ArrayList<>();
+ auditIds.add("7");
Review Comment:
It looks like this magic number is still there, and it is recommended to
extract it as a constant in this class, with an explanation of what it means.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
