yunqingmoswu commented on code in PR #7416:
URL: https://github.com/apache/inlong/pull/7416#discussion_r1115341835
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleTableSourceFactory.java:
##########
@@ -127,7 +118,17 @@ public DynamicTableSource createDynamicTableSource(Context
context) {
startupOptions,
sourceMultipleEnable,
inlongMetric,
- inlongAudit);
+ inlongAudit,
Review Comment:
There are too many parameters here. If you add a parameter later, you need
to modify the constructor. It is recommended to abstract a data model and
encapsulate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
