healchow commented on code in PR #7424:
URL: https://github.com/apache/inlong/pull/7424#discussion_r1117885017
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkService.java:
##########
@@ -245,4 +245,8 @@ public interface StreamSinkService {
*/
Boolean updateAfterApprove(List<SinkApproveDTO> sinkApproveList, String
operator);
+ /**
+ * Converts a json string to a sinkFields
+ */
Review Comment:
Please add `@param` and `@return` for public methods.
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongStreamController.java:
##########
@@ -169,4 +176,10 @@ public Response<Boolean> delete(@RequestParam String
groupId, @RequestParam Stri
return Response.success(streamService.delete(groupId, streamId,
username));
}
+ @RequestMapping(value = "/stream/parseFields", method = RequestMethod.POST)
+ @ApiOperation(value = "parse inlong stream fields")
Review Comment:
1. "parse inlong stream fields" -> "Parse inlong stream fields from JSON
string"
2. Add `@ApiImplicitParam` for `fieldsJson`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
